fix[N15] Unnecessary import statements #112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: chrismaree <christopher.maree@gmail.com>
chrismaree
added
the
OZ Audit - March
mrice32
reviewed
Mar 17, 2022
Contributor
mrice32
left a comment
mrice32
left a comment
There was a problem hiding this comment.
Missed LpTokenFactoryInterface
nicholaspai
reviewed
Mar 17, 2022
contracts/Ethereum_SpokePool.sol
Outdated
| import "@openzeppelin/contracts/token/ERC20/IERC20.sol"; | ||
|
|
||
| import "./SpokePool.sol"; | ||
| import "./SpokePoolInterface.sol"; |
Member
There was a problem hiding this comment.
Can also remove SpokePoolInterface
nicholaspai
reviewed
Mar 17, 2022
contracts/Optimism_SpokePool.sol
Outdated
|
|
||
| import "./SpokePool.sol"; | ||
| import "./interfaces/WETH9.sol"; | ||
| import "./SpokePoolInterface.sol"; |
Member
There was a problem hiding this comment.
I think you can remove SpokePoolInterface
nicholaspai
reviewed
Mar 17, 2022
| import "./SpokePool.sol"; | ||
| import "./PolygonTokenBridger.sol"; | ||
| import "./interfaces/WETH9.sol"; | ||
| import "./SpokePoolInterface.sol"; |
Member
There was a problem hiding this comment.
I think you can remove SpokePoolInterface
Member
Author
There was a problem hiding this comment.
and in the Arbitrum one!
nicholaspai
approved these changes
Mar 17, 2022
Member
nicholaspai
left a comment
nicholaspai
left a comment
There was a problem hiding this comment.
LGTM but you forgot one removal: the IERC20 in the LPTokenFactoryInterface
This was referenced Apr 6, 2022
This was referenced May 3, 2022
Merged
This was referenced May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The below list outlines contract import statements that are unnecessary:
The WETH9 and Lockable imports are not used in the Ethereum_Adapter contract.
The CrossDomainEnabled, IL1StandardBridge, and Lockable imports are not used in the
Polygon_Adapter contract.
The WETH9 and IERC20 imports are not used in the Arbitrum_Adapter contract.
The AdapterInterface interface is imported twice in the Arbitrum_Adapter contract.
The WETH9 and SpokePoolInterface imports are not used in the Ethereum_SpokePool contract.
The IERC20 import in the LpTokenFactoryInterface interface is unused.
The MerkleLib is imported twice in the SpokePool contract.
Solution
Removed unnecessary imports. I also changed the ordering of some of them to be more consistant (implementation, then interfaces, then external).